-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PhotonClient] Vite and Typescript complete refactor #884
[PhotonClient] Vite and Typescript complete refactor #884
Conversation
… and i completely agree with the origonal photon vision dev who decided to do it because devlopment is so hard without it to validate things, but i might remove it later so that I can make sure a no camera enviorment still works even though the backend validates that stuff already
this is prob wrong but pinia stores ig
When trying to calibrate I get
I'm not able to reproduce. It has something to do with multi-cam |
There's also been a couple times where the camera dropdown on the right doesn't actually switch between cameras. |
This is the response when you try to end calibration, not start it? Did the UI click start or end calibration when this request was sent? For ending calibration, this is excepted response when there are 0/12 snapshots. |
Does the backend send new camera settings whenever it has a new camera updated? Else, the dropdown field's model might not have a reactive update causing it to not show the new camera's name. |
Not 100% sure but I think it is because |
single variable change to work with env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we ball
With this PR also comes a requirement for all future Pull Requests that if they change pipeline settings or other data exchange-related settings, their typing has to be updated in the frontend as well. This hasn't been done in the past leading to many bugs in the frontend due to it referencing backend data that didn't exist because it was removed or changed in a backend PR.
TODO