Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] remove opencv dependency for robot installations #1580

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

LucienMorey
Copy link
Contributor

We have more dependency problems attached to opencv....

Rio-related installations are broken because some things don't exist. This is not an issue worth solving by fighting the dependency manager. Python is a client library and will only ever have this dependency for simulation things. IE let's never try to install opencv things because we wont actually need them.

@mcm001, we would be super grateful if you could make another release with this being merged. This brings us to a baseline where teams will be able to install the 2025 Python library. I have now tested this myself and am confident that this is the end of installation nightmares for now....

@LucienMorey LucienMorey requested a review from a team as a code owner November 17, 2024 02:02
Copy link
Member

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@mcm001
Copy link
Contributor

mcm001 commented Nov 17, 2024

Opencv could be used outside of simulation for multi tag on Rio, but I believe that isn't actually implemented in python at all right?

@mcm001 mcm001 changed the title remove opencv dependency for robot installations [Python] remove opencv dependency for robot installations Nov 17, 2024
@mcm001 mcm001 merged commit 097e641 into PhotonVision:master Nov 17, 2024
34 of 35 checks passed
@LucienMorey
Copy link
Contributor Author

That is true. buuuuutttt...... you identified how few teams use python and I bet even fewer try to do vision processing on the rio with it :p

@mcm001
Copy link
Contributor

mcm001 commented Nov 17, 2024

lol. tag cutting in work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants