Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create opinionated pull request template #1561

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+16 −0
Open

Create opinionated pull request template #1561

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
641bc0d
Create pull_request_template.md
mcm001 Nov 12, 2024
c4182f9
Update pull_request_template.md
mcm001 Nov 12, 2024
46cdc4f
Update pull_request_template.md
mcm001 Nov 12, 2024
edb3f14
Update .github/pull_request_template.md
mcm001 Nov 12, 2024
08deda9
Update pull_request_template.md
mcm001 Nov 12, 2024
04f63bd
Update pull_request_template.md
spacey-sooty Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
## Description

What changed? Why? (the code + comments should speak for itself on the "how")

Fun screenshots ir a cool video or something are super helpful as well. If this touches platform-specific behavior, this is where test evidence should be collected.
mcm001 marked this conversation as resolved.
Show resolved Hide resolved
spacey-sooty marked this conversation as resolved.
Show resolved Hide resolved

## Meta
mdurrani808 marked this conversation as resolved.
Show resolved Hide resolved

Merge checklist:
- [ ] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes
- [ ] The description documents the _what_ and _why_
- [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
spacey-sooty marked this conversation as resolved.
Show resolved Hide resolved
- [ ] If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be for that year? 2025.X.X or whatever unless this is just intentional to make it always compatible back to then

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current update plan is to always be able to support configs from last years last stable build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but is there a test for loading the last stable config?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes added in #1487

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the intent is that this template would be updated when we need to bump that.

- [ ] If this PR addresses a bug, a regression test for it is added
Loading