Fix videomode is null #1513
Merged
Fix videomode is null #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#18 (comment) idk why i chose to add this. If it doesn't break anything I don't have a problem sending it? |
|
I would assume if the camera is not connected it doesn't have a video mode right? But also since we don't handle reconnects we need to know what it will be when it boots/connects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a weird edge case at least with arducam/broken arducams/used arducams where cscore will see it when pv starts but not be able to connect to it. If we always read out the "current" video mode instead of null when it is disconnected things will work. If the camera is disconnected while we try to change the video mode when we get the current video mode it will tell us what we wanted to set it to. Then when the camera reconnects it will be in that video mode.