Reduce log spam if network monitor fails #1494
Conversation
This prevents spamming of the logs by the network interface device
monitor by:
- checking to make sure the device file exists before starting the
monitoring task
- cancelling the task if it throws an exception
| logger.error("Could not check network status for " + devName, e); | ||
| // Cancel the task to avoid spamming the logs | ||
| logger.info("Cancelling task " + taskName); | ||
| TimedTaskManager.getInstance().cancelTask(taskName); |
There was a problem hiding this comment.
Just reviewing the diff - if this task is canceled, do we have a way to bring it back if the interface comes back up?
There was a problem hiding this comment.
The cancellation is only triggered when the this throws an error, which I think only happens if Files.readstring() fails. An alternative is to keep the task but only log an error once. That way, if it stops throwing, the monitor will continue working. I'll push a commit with this logic.
There was a problem hiding this comment.
Which I think could only happen if the file doesn't exist? Maybe we need something like ROS_LOG_ONCE lol.
There was a problem hiding this comment.
That's my assumption. But maybe there could be another filesystem problem that could cause it to transiently fail. The only downside of not cancelling is that it leaves the monitor running and triggering an exception every 5 seconds.
photon-core/src/main/java/org/photonvision/common/networking/NetworkManager.java
Show resolved
Hide resolved
This prevents spamming of the logs by the network interface device monitor by: