Camera view updated to better respond to state #1437
Conversation
In the previous camera view code, the frame didn't respond well to losses of connection, camera aspect ratio changes, etc. Instead of changing the stream src, we can layer the camera view on top of the loading image, so that any time the camera signal is lost, even if it's because PhotonVision is restarting or you lose connection to the robot, the loading image is still in memory. This also fixes the responsiveness to connection loss.
|
Not blocking this PR: does this open the door to not trying to load both streams while looking only at one? Right now if you open devtools you can see both streams are being loaded even if only one is visible. |
This PR as is doesn't solve that problem, but if it's something you want to solve, looks like a fairly simple change. |
…into users/stjust/camera-view
Latest commit fixes this. |
|
No way it was as simple as that, great stuff. I'm out this weekend but will try to draft someone else to try it out |
|
I can tonight ~5 hrs. |
In the previous camera view code, the frame didn't respond well to losses of connection, camera aspect ratio changes, etc.
Instead of changing the stream src, we can layer the camera view on top of the loading image, so that any time the camera signal is lost, even if it's because PhotonVision is restarting or you lose connection to the robot, the loading image is still in memory. This also fixes the responsiveness to connection loss.
This also only loads a stream if it is meant to be visible in the UI.