-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create timesync JNI for testing client #1433
Conversation
Upstream - wpilibsuite/allwpilib#7007 |
@mcm001 do you think you could make a sequence diagram of this protocol? |
I am certainly capable of producing a drawing, yes. :P |
Idk I'll ask ChatGPT to generate me some plantuml |
d020419
to
966bf88
Compare
...-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
Outdated
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/vision/frame/provider/USBFrameProvider.java
Outdated
Show resolved
Hide resolved
photon-lib/src/main/java/org/photonvision/simulation/VisionSystemSim.java
Outdated
Show resolved
Hide resolved
photon-lib/src/test/java/org/photonvision/PhotonCameraTest.java
Outdated
Show resolved
Hide resolved
703bd04
to
43d16c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the server to be created on the roborio exactly once when a photoncamera is created
photon-core/src/main/java/org/photonvision/common/dataflow/networktables/NTDataPublisher.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some general grammar suggestions because its 12:30AM.
photon-core/src/main/java/org/photonvision/common/dataflow/networktables/TimeSyncManager.java
Show resolved
Hide resolved
75eb82d
to
5e5d163
Compare
16891a7
to
11b250a
Compare
This also bumps to 2025 beta 1. |
Beta 1 was merged last night. |
ah that explains |
WOBOTLOGTIMESYNC.zip |
Creates new timesync client + server + docs. By default. photoncamera will create a new server when instantiated. the coprocessor will use the NT client/server mode to switch the TSP role.
We've chosen to do this over NTP or PTP because we want to syncronize against the Rio's FPGA clock, which means we need to exist both entirely in userland and in the robot program executable. The Rio's NIC also does not support hardware timestamping.