Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create timesync JNI for testing client #1433

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Sep 24, 2024

image

Creates new timesync client + server + docs. By default. photoncamera will create a new server when instantiated. the coprocessor will use the NT client/server mode to switch the TSP role.

We've chosen to do this over NTP or PTP because we want to syncronize against the Rio's FPGA clock, which means we need to exist both entirely in userland and in the robot program executable. The Rio's NIC also does not support hardware timestamping.

@Alextopher
Copy link
Contributor

Upstream - wpilibsuite/allwpilib#7007

@Alextopher
Copy link
Contributor

@mcm001 do you think you could make a sequence diagram of this protocol?

@mcm001
Copy link
Contributor Author

mcm001 commented Sep 28, 2024

I am certainly capable of producing a drawing, yes. :P

@mcm001
Copy link
Contributor Author

mcm001 commented Sep 28, 2024

Idk I'll ask ChatGPT to generate me some plantuml

@mcm001 mcm001 force-pushed the 20240923_timesyncjni branch 4 times, most recently from 703bd04 to 43d16c7 Compare October 26, 2024 01:20
@mcm001 mcm001 marked this pull request as ready for review October 26, 2024 03:47
@mcm001 mcm001 requested a review from a team as a code owner October 26, 2024 03:47
Copy link
Contributor

@Juniormunk Juniormunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the server to be created on the roborio exactly once when a photoncamera is created

Copy link
Contributor

@DeltaDizzy DeltaDizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some general grammar suggestions because its 12:30AM.

@mcm001 mcm001 force-pushed the 20240923_timesyncjni branch 2 times, most recently from 75eb82d to 5e5d163 Compare October 30, 2024 02:09
@Juniormunk
Copy link
Contributor

This also bumps to 2025 beta 1.

@mcm001
Copy link
Contributor Author

mcm001 commented Oct 31, 2024

Beta 1 was merged last night.

@mcm001 mcm001 merged commit 37aaa49 into PhotonVision:master Oct 31, 2024
32 checks passed
@mcm001 mcm001 deleted the 20240923_timesyncjni branch October 31, 2024 15:27
@Juniormunk
Copy link
Contributor

ah that explains

@mcm001
Copy link
Contributor Author

mcm001 commented Nov 1, 2024

WOBOTLOGTIMESYNC.zip
Test data from a real robot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants