[photon-client] Upgrade to Vite 5 #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stephenjust
commented
Aug 24, 2024
stephenjust
commented
- Bumps minimum NodeJS requirement to v18 (already used as part of official builds)
- Prerequisite for latest VueJS
* Bumps minimum NodeJS requirement to v18 (already used as part of official builds) * Prerequisite for latest VueJS
|
Have you checked that the UI build still works and there aren't any new errors in the browser console? I'm still a bit scared from the pnpm update we had to roll back |
Yes, the UI build ran fine locally and on my OPi5 Plus. No new errors in the console. |
mcm001
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.