Set default pipeline idx in PipelineManager constructor #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdurrani808
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Looks good to me, the naming is a little confusing given requested / current but logically it seems good. I'm not able to test but I believe you have, would be good to spin up some code and ensure that changing the pipeline via PhotonLib still works as intended.
photon-core/src/main/java/org/photonvision/vision/processes/PipelineManager.java
Show resolved
Hide resolved
|
Yeah I tested switching in/out of driver mode, i'll make sure to test changing pipeline index. Would be really cool to set up integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1285