-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Camera Index Assignment. #1031
Merged
mcm001
merged 9 commits into
PhotonVision:master
from
BytingBulldogs3539:Index-Assignment-Fix
Dec 1, 2023
Merged
Fix Camera Index Assignment. #1031
mcm001
merged 9 commits into
PhotonVision:master
from
BytingBulldogs3539:Index-Assignment-Fix
Dec 1, 2023
Commits on Nov 29, 2023
-
appears that the remove method from arraylist was not functioning properly.
Configuration menu - View commit details
-
Copy full SHA for 984b100 - Browse repository at this point
Copy the full SHA 984b100View commit details -
Revert "Rewrite assigneCameraIndex."
This reverts commit 984b100.
Configuration menu - View commit details
-
Copy full SHA for 03d7f4b - Browse repository at this point
Copy the full SHA 03d7f4bView commit details -
Update Equals Method for USB Camera Source.
Cleaner fix to the bug of multiple cameras of the same type aka dual arducam ov9281 uc844 not working. The past equals would result in false positives.
Configuration menu - View commit details
-
Copy full SHA for b48cb8a - Browse repository at this point
Copy the full SHA b48cb8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e868522 - Browse repository at this point
Copy the full SHA e868522View commit details
Commits on Dec 1, 2023
-
Add Unit Tests, Fix QuirkyCamera no base name.
One of the reasons the that usbcamerasource equals method used to incorrectly determine equality was because the quirkycamera object didn't have a basename. When a camera that had a quirk was found it would set equal to a predefined quirkycamera without changing the name first. Add unit test that will better test the equality of two usbcamerasources. This required a few changes to allow creating a fake usbcamerasource.
Configuration menu - View commit details
-
Copy full SHA for 94ebcb5 - Browse repository at this point
Copy the full SHA 94ebcb5View commit details -
Merge branch 'Index-Assignment-Fix' of https://github.com/BytingBulld…
…ogs3539/photonvision into Index-Assignment-Fix
Configuration menu - View commit details
-
Copy full SHA for c6d5542 - Browse repository at this point
Copy the full SHA c6d5542View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab5e934 - Browse repository at this point
Copy the full SHA ab5e934View commit details -
Configuration menu - View commit details
-
Copy full SHA for 310a973 - Browse repository at this point
Copy the full SHA 310a973View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3aa4702 - Browse repository at this point
Copy the full SHA 3aa4702View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.