-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update C++ Simulation to match Java #1026
Conversation
This wasn't based correctly so make sure to merge with master as some stuff is missing. |
On my fork it says its ahead by 11 commits with master branch. What is missing? |
Sync your master branch with our master branch. There should be a button |
It looks OK to me? What am I missing |
photon-targeting/src/main/java/org/photonvision/targeting/PhotonTrackedTarget.java
Outdated
Show resolved
Hide resolved
photon-targeting/src/main/native/include/photon/targeting/PhotonTrackedTarget.h
Outdated
Show resolved
Hide resolved
Just blocked waiting for a wpilib beta release rn I believe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imagine actually reviewing PRs
This is a PR that updates the C++ version of Photonlib to support the new simulation features.
TODO: