Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reboot photon on settings zip upload #1020

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Reboot photon on settings zip upload #1020

merged 2 commits into from
Nov 22, 2023

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Nov 22, 2023 •
edited
Loading

We used to (2023) do this, but don't anymore for some reason?

@mcm001 mcm001 marked this pull request as ready for review November 22, 2023 03:07
@mcm001 mcm001 requested a review from a team as a code owner November 22, 2023 03:07
@srimanachanta
Copy link
Member

I think I may have accidentally removed this when doing the photon-server updates

gerth2
gerth2 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@gerth2 gerth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key assumption - the 200 isn't sent till files are written to disk. This seems like a reasonable assumption, we can always boost our PR count if I"m wrong. yeet.

@gerth2 gerth2 merged commit 5d93515 into PhotonVision:master Nov 22, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerth2 gerth2 gerth2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcm001 @srimanachanta @gerth2