fix todos

PhotonVision · Jul 29, 2023 · 982fb8a · 982fb8a
1 parent f3f7cca
commit 982fb8a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/photon-client/src/components/common/cv-range-slider.vue b/photon-client/src/components/common/cv-range-slider.vue
@@ -32,9 +32,11 @@ const localValue = computed<[number, number]>({
   set: v => emit("input", v)
 });
 
-// TODO do this better
-const changeFromSlot = (v, i) => {
-  localValue.value = localValue.value.map((value, index) => index === i ? v : value) as [number, number];
+const changeFromSlot = (v: number, i: number) => {
+  // localValue.value must be replaced for a reactive change to take place
+  const temp = localValue.value;
+  temp[i] = v;
+  localValue.value = temp;
 };
 </script>
 

diff --git a/photon-client/src/components/dashboard/CamerasCard.vue b/photon-client/src/components/dashboard/CamerasCard.vue
@@ -71,7 +71,6 @@ const fpsTooLow = computed<boolean>(() => {
       </div>
     </v-card-title>
     <v-divider style="border-color: white" />
-    <!-- TODO do this better -->
     <v-row
       class="pl-3 pr-3 pt-3 pb-3"
       style="flex-wrap: nowrap; justify-content: center"