More carefully check file creation status (#958)

PhotonVision · Oct 17, 2023 · 441caf0 · 441caf0
1 parent 47bd077
commit 441caf0
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/photon-server/src/main/java/org/photonvision/server/RequestHandler.java b/photon-server/src/main/java/org/photonvision/server/RequestHandler.java
@@ -537,17 +537,23 @@ private static Optional<File> handleTempFileCreation(UploadedFile file) {
                 new File(Path.of(System.getProperty("java.io.tmpdir"), file.filename()).toString());
         boolean makeDirsRes = tempFilePath.getParentFile().mkdirs();
 
-        if (!makeDirsRes) {
+        if (!makeDirsRes && !(tempFilePath.getParentFile().exists())) {
             logger.error(
-                    "There was an error while uploading " + file.filename() + " to the temp folder!");
+                    "There was an error while creating "
+                            + tempFilePath.getAbsolutePath()
+                            + "! Exists: "
+                            + tempFilePath.getParentFile().exists());
             return Optional.empty();
         }
 
         try {
             FileUtils.copyInputStreamToFile(file.content(), tempFilePath);
         } catch (IOException e) {
             logger.error(
-                    "There was an error while uploading " + file.filename() + " to the temp folder!");
+                    "There was an error while copying "
+                            + file.filename()
+                            + " to the temp file "
+                            + tempFilePath.getAbsolutePath());
             return Optional.empty();
         }