Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logserver: Support for query with block number and so on #1352

Merged
merged 5 commits into from
Jul 31, 2023

Conversation

kvinwang
Copy link
Collaborator

@kvinwang kvinwang commented Jul 31, 2023

This PR implements the feature requests from @Leechael.

  • Setting the start sequence relative-to the next_sequence.
    The filter argument from now can be negative, which means counting back from the end like the list indexing in Python.
    For example given next_sequence = 100, when from = -2 means from = 98.
  • Filtering records with block number if given.
    A new argument blockNumber is added to the GetLog action.
  • Adding an action named GetInfo which returns infomations as shown below:
    {
      "currentNumberOfRecords": 4,
      "estimatedCurrentSize": 675,
      "memoryCapacity": 1048576,
      "memoryUsage": 22519,
      "nextSequence": 4,
      "programVersion": [0, 1, 0]
    }

@kvinwang kvinwang requested a review from Leechael July 31, 2023 09:55
Copy link
Contributor

@Leechael Leechael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I will do SDK compatible check later.

@kvinwang kvinwang merged commit 85cf4fc into master Jul 31, 2023
8 checks passed
@kvinwang kvinwang deleted the logserver-ext branch July 31, 2023 14:26
@Leechael Leechael mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants