Merge deposit() and contract call() into a single call #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is picked from #1265. Since #1265 would not be released in pruntime v2.0.2, we may want to pick this runtime ABI breaking change out to release in advance.
In pink query, caller can optionally fill an arbitrary number the the arg
depositwhich would be deposited to the caller account before calling the contract so that the runtime can finish the gas estimation even the caller doesn't have enough balance in the cluster to pay the execution.So there were two call to the pink runtime if non-zero deposit was given:
runtime.deposit(amout)runtime.call(contract_id)There is no problem with in memory trie storage. However, for kvdb backend in #1265 we don't implement an extra cache layer for the DB, the effect of the first call
runtime.deposit()would be dropped at the time callingruntime.call().The simplest solution for this issue it merge the to runtime calls into one, that's what this PR does.