Errors fixed #3
Merged
Errors fixed #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidstvn
requested changes
Apr 26, 2024
| @@ -14,6 +14,7 @@ public class TorpedoStore { | |||
|
|
|||
| private int torpedoCount = 0; | |||
|
|
|||
| private Random generator = new Random(); | |||
There was a problem hiding this comment.
Ez a random nem jelent kriptografiai kockazatot, mert csak jatektechnikai vonatkozasai vannak, nincs koze szemelyes adatokhoz.
| @@ -30,18 +31,18 @@ public TorpedoStore(int numberOfTorpedos){ | |||
|
|
|||
| public boolean fire(int numberOfTorpedos){ | |||
| if(numberOfTorpedos < 1 || numberOfTorpedos > this.torpedoCount){ | |||
| new IllegalArgumentException("numberOfTorpedos"); | |||
| throw new IllegalArgumentException("numberOfTorpedos"); | |||
There was a problem hiding this comment.
Ez az elvart viselkedes megfelelo.
| double r = generator.nextDouble(); | ||
|
|
||
| if (r >= FAILURE_RATE) { | ||
| // successful firing | ||
| this.torpedoCount =- numberOfTorpedos; | ||
| this.torpedoCount -= numberOfTorpedos; |
There was a problem hiding this comment.
Megfelelo javitas, ez az elvart viselkedes.
|
A valtoztatasok megfeleloek, a random nem tartalmaz security risket. |
davidstvn
approved these changes
Apr 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I solved all three errors in 3 commits. Please review it to be sure.