perlapi: Combine all sv_catpv() forms into one group #22373
Conversation
With this commit, it is now possible to have continuation lines on apidoc lines in the source
The function it merely wraps is const
These are macros, so the const has no compilation effect, but the function the macros expand to does have a const, so make them match.
|
For consistency with all your other "Combine API entries" pull requests, I believe that the changes to autodoc.pl itself (de6c30e) should go into a separate pull request. |
This also changes the formal parameter name of some of the macros so that all forms in the group have consistent parameter names.
|
The Subject line for this p.r. is slightly misleading. Last month, in this commit: ... you grouped these API functions together: Can you briefly note why they should not go into the section discussed in this pull request? (I concede that that would make this section very large.) |
| # Count lines easier | ||
| my $get_next_line = sub { $line_num++; return <$fh> }; | ||
| # Count lines easier and handle apidoc continuation lines | ||
| my $get_next_line = sub { my $contents = <$fh>; |
There was a problem hiding this comment.
Can we wrap this after the { and indent the sub body the normal amount instead of half a screen?
| /$1/x) | ||
| { | ||
| my $next = <$fh>; | ||
| last unless defined $next; |
There was a problem hiding this comment.
This needs a no warnings 'exiting';
They do different things. The functions described here are like The pvf functions concatenate a formatted string, so like |
This also changes the formal parameter name of some of the macros so
that all forms in the group have consistent parameter names.