-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makerel: always use ustar format #22273
base: blead
Are you sure you want to change the base?
Conversation
When generating release tarballs, always use ustar format. The ustar format is one of the POSIX standard formats, and is the basis for future tar formats. It supports all of the features we need to create a release tarball. The newer formats support extended attributes that can produce warnings when extracting on some systems. This includes attributes like LIBARCHIVE.xattr.com.apple.quarantine, set on macOS systems on files downloaded from the internet. Using the ustar format prevents those attributes from being stored in the tarball and avoids the warnings.
Fixes #22245 |
I don't know enough about the different |
This comment was marked as resolved.
This comment was marked as resolved.
See Perl-Toolchain-Gang/ExtUtils-MakeMaker#349 for discussion there. |
Going by the discussion in Perl-Toolchain-Gang/ExtUtils-MakeMaker#349 wouldn't we be better off using Since:
while ptar always produces ustar |
All of the tar implementations we care about support Producing an empty tarball requires a rather specific system setup that is not common. It's something I ran into before, but is no longer relevant to me. It's also more of an issue for CPAN releases, because they are often uploaded without being tested directly.
|
When generating release tarballs, always use ustar format. The ustar format is one of the POSIX standard formats, and is the basis for future tar formats. It supports all of the features we need to create a release tarball. The newer formats support extended attributes that can produce warnings when extracting on some systems. This includes attributes like LIBARCHIVE.xattr.com.apple.quarantine, set on macOS systems on files downloaded from the internet. Using the ustar format prevents those attributes from being stored in the tarball and avoids the warnings.