Proposal to have ExtUtils::MakeMaker maintain all rpath arguments #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leont
reviewed
Mar 23, 2023
Leont
reviewed
Mar 23, 2023
added 2 commits
March 23, 2023 19:42
ExtUtils::MakeMaker previously dropped any rpath argument that isn't an existing directory. This is too restrictive because: * the directory could be created after the Makefile is generated * rpaths can be the variables $ORIGIN on Linux or @rpath, @loader_path, or @executable_path on Mac See Perl-Toolchain-Gang#439
Since the rpath value may also be consumed in a test in Makefile.PL where it doesn't need to be escaped, it's inconvenient to unescape it there.
|
I've approved the CI to run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtUtils::MakeMaker previously dropped any rpath argument that isn't an existing directory. This is too restrictive because:
Also, do a Makefile escape of any single '$' in the rpath value ($ -> $$). Since the rpath value may also be consumed in a test in Makefile.PL where it doesn't need to be escaped, it's inconvenient to unescape it there.
See #439