Fix indicator interval type

pkg/health/types.go

@@ -67,7 +67,7 @@ func (is *IndicatorSettings) Validate() error {
 	if is.FailuresTreshold <= 0 {
 		return fmt.Errorf("validate Settings: FailuresTreshold must be > 0")
 	}
-	if is.Interval < 30 {
+	if is.Interval < 30*time.Second {
 		return fmt.Errorf("validate Settings: Minimum interval is 30 seconds")
 	}
 	return nil

pkg/sm/sm.go

@@ -23,12 +23,10 @@ import (
 	"fmt"
 	h "github.com/InVisionApp/go-health"
 	l "github.com/InVisionApp/go-logger/shims/logrus"
+	"github.com/Peripli/service-manager/api/osb"
 	"github.com/Peripli/service-manager/pkg/health"
 	"net/http"
 	"sync"
-	"time"
-
-	"github.com/Peripli/service-manager/api/osb"
 
 	"github.com/Peripli/service-manager/storage/catalog"
 
@@ -152,11 +150,6 @@ func New(ctx context.Context, cancel context.CancelFunc, cfg *config.Settings) (
 		cfg:                 cfg,
 	}
 
-	err = smb.installHealth(cfg.Health)
-	if err != nil {
-		return nil, fmt.Errorf("error adding health chech to sm: %s", err)
-	}
-
 	// Register default interceptors that represent the core SM business logic
 	smb.
 		WithCreateInterceptorProvider(types.ServiceBrokerType, &interceptors.BrokerCreateCatalogInterceptorProvider{
@@ -187,8 +180,6 @@ func (smb *ServiceManagerBuilder) Build() *ServiceManager {
 	}
 
 	// setup server and add relevant global middleware
-	smb.installHealth()
-
 	srv := server.New(smb.cfg.Server, smb.API)
 	srv.Use(filters.NewRecoveryMiddleware())
 
@@ -218,7 +209,7 @@ func (smb *ServiceManagerBuilder) installHealth() error {
 		if err := healthz.AddCheck(&h.Config{
 			Name:     indicator.Name(),
 			Checker:  indicator,
-			Interval: indicator.Interval() * time.Second,
+			Interval: indicator.Interval(),
 			Fatal:    indicator.Fatal(),
 		}); err != nil {
 			return err