-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shape error for tensor-like parameters in pauli arithmetic fixed (Addition to PR: #6562) #6681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thmetic + changelog
Co-authored-by: David Wierichs <[email protected]>
Co-authored-by: David Wierichs <[email protected]>
Co-authored-by: David Wierichs <[email protected]>
Co-authored-by: David Wierichs <[email protected]>
Co-authored-by: David Wierichs <[email protected]>
Co-authored-by: Christina Lee <[email protected]>
…tangle test cases
…tangle test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
I added Pauli string decompositions for non-parametrized gates in PR: #6562. In the initial version of PR: #6562 also included Pauli string decompositions for single-qubit parametrized gates - they had to be removed for now because of issues in CI testing - but the bug below remains relevant as it might surface again once more Pauli-reps are added:
Pennylane can exploit Pauli string representations when, for example, computing
The example above works as intended, but for tensor-like parameters as in
or
a shape error is returned. The code above should work since
RX
andRY
support tensor-like (flattened) parameters as it can be seen fromDescription of the Change:
I added an outer product in
pauli_arithmetic
.Benefits:
PhaseShift gate
could be added - this was not possible before as thePCPhase
gate used thepauli_arithmetic
, which gave an error in the pytests.Possible Drawbacks:
None
Related GitHub Issues:
#6243 and PR: #6562