forked from openedx/xblock-lti-consumer
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PADV-412: Add LTI 1.3 re-usable configuration ADR #5
Open
kuipumu
wants to merge
6
commits into
pearson-release/olive.main
Choose a base branch
from
vue/PADV-412
base: pearson-release/olive.main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squirrel18
reviewed
Apr 14, 2023
for pluggable and re-usable LTI configurations on the lti_store plugin and | ||
xblock-lti-consumer XBlock. | ||
|
||
The #239 issue on xblock-lti-consumer added support for LTI 1.1 pluggability, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add here all the links you mention. @kuipumu
anfbermudezme
approved these changes
Apr 17, 2023
Squirrel18
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://agile-jira.pearson.com/browse/PADV-412
Description
This PR adds an ADR document where we will address the discovery issue on the ticket PADV-412, the document contains information on LTI 1.3 re-usable configuration feature. these are a description of a general approach to achieving this. We will use this ADR to discuss the LTI 1.3 re-usable configuration feature implementation.
Type of Change
Reviewers