PADV-1658 test: Shared Components Test Suite #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandodev-net
changed the title
nandodev-net
force-pushed
the
vue/PADV-1658
branch
from
c8e476c
to
161a544
Compare
01001110J
reviewed
Sep 11, 2024
Sure!, but given so many tests of that tool that I don't know well, for me they were very useful. I Will erased all those comments |
01001110J
approved these changes
Sep 11, 2024
JuanDavidBuitrago
approved these changes
Sep 12, 2024
nandodev-net
force-pushed
the
vue/PADV-1658
branch
from
6e7af87
to
c8548d9
Compare
nandodev-net
force-pushed
the
vue/PADV-1658
branch
from
c8548d9
to
29cf066
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets
Description
This PR focuses on enhancing and completing the test coverage for shared components utilized across the application. The aim is to ensure that all reusable components are thoroughly tested to guarantee their reliability and robustness.
Includes:
Shared Components:
AlertMessage: Verifies rendering, message display, and error handling logic.
LabDetailsCard: Tests for correct lab detail representation, edge cases, and data handling.
LabDetailsChartCard: Ensures that chart data is correctly processed and displayed.
Table: Covers table rendering, data population, empty states, and interactions like sorting and pagination.
TableFilter: Validates filtering logic, form handling, and integration with the table component.
DashboardLaunchButton: Ensures button visibility, click events, error handling, and integration with the dashboard launch logic.
JsonViewer: Verifies JSON editor initialization, configuration, and cleanup behavior.
Changes Made
This PR aims to achieve full coverage for all shared components, ensuring they function correctly in all intended use cases. Expected coverage for all shared components is at least 87%
How To Test
npm iin your MFE folder.npm test -- --verboseVerify that all tests pass and that coverage reports indicate the coverage for the targeted files.
Component Tests
Shared