PADV-1475 test: Creating test for shared componets and helper functions. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandodev-net
force-pushed
the
vue/PADV-1475
branch
6 times, most recently
from
398cbf5
to
161a544
Compare
nandodev-net
changed the title
01001110J
reviewed
Sep 11, 2024
Comment on lines
12
to
17
| import { logError } from '@edx/frontend-platform/logging'; | ||
| import LabSummary from '../index'; | ||
| import '@testing-library/jest-dom'; | ||
| import { columns } from '../columns'; | ||
| import { formatUnixTimestamp } from '../../../helpers'; |
There was a problem hiding this comment.
Suggested change
| import { logError } from '@edx/frontend-platform/logging'; | |
| import LabSummary from '../index'; | |
| import '@testing-library/jest-dom'; | |
| import { columns } from '../columns'; | |
| import { formatUnixTimestamp } from '../../../helpers'; | |
| import { logError } from '@edx/frontend-platform/logging'; | |
| import '@testing-library/jest-dom'; | |
| import LabSummary from '../index'; | |
| import { columns } from '../columns'; | |
| import { formatUnixTimestamp } from '../../../helpers'; |
|
@nandodev-net You have a lot of unnecessary inline comments, even in Spanish. |
@JuanDavidBuitrago Sure, but given so many tests of that tool that I don't know well, for me they were very useful. Now that I know the approach makes sense, I clean them |
jest.config.js
Outdated
Comment on lines
2
to
9
| // Your existing Jest configuration options | ||
| moduleNameMapper: { | ||
| '^views/(.*)$': '<rootDir>/src/views/$1', | ||
| '^shared/(.*)$': '<rootDir>/src/shared/$1', | ||
| '^constants/(.*)$': '<rootDir>/src/constants/$1', | ||
| // Add more mappings as needed | ||
| '\\.(css|less|scss|sass)$': 'identity-obj-proxy', // Mock CSS modules | ||
| '\\.(svg|png|jpg|jpeg|gif)$': '<rootDir>/__mocks__/fileMock.js', // Mock files like images |
There was a problem hiding this comment.
These inline comments are necessaries? @nandodev-net
JuanDavidBuitrago
approved these changes
Sep 12, 2024
01001110J
approved these changes
Sep 12, 2024
nandodev-net
force-pushed
the
vue/PADV-1475
branch
from
f9264fd
to
692c084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets
Description
This PR aims to improve and finalize the test coverage for the core application components and helper functions. It includes comprehensive test suites for the following components:
ClassRoster:
LabSummary:
LabDetails:
Helpers/Index.js: Covers all utility functions and ensures their expected behavior across different scenarios.
Changes Made
This PR targets increasing the test coverage for the critical parts of the application, particularly focusing on routing, main view functionality, and helper functions. Expected coverage:
How To Test
npm iin your MFE folder.npm test -- --verboseVerify that all tests pass and that coverage reports indicate the coverage for the targeted files.
Component Tests
Helpers
Views
ClassRoster
LabSummary
LabDetails
Core