Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] 이동봉사자, 모집자 휴대폰 번호 중복 검사 API 구현 #169

Merged
merged 4 commits into from
May 2, 2024
Merged

[Feature] 이동봉사자, 모집자 휴대폰 번호 중복 검사 API 구현 #169

merged 4 commits into from
May 2, 2024

Conversation

kyeong-hyeok
Copy link
Member

💡 연관된 이슈

close #167

📝 작업 내용

  • 이동봉사자, 모집자 휴대폰 번호 중복 검사 API 구현
  • Controller 테스트 코드 추가

💬 리뷰 요구 사항

  • API 응답값에 이동봉사자는 SocialType이 있고, 모집자는 없습니다.

@kyeong-hyeok kyeong-hyeok added ✨ Feature 기능 개발 Priority: Low 우선순위 낮음 🐯 Koeyhk 담당자 labels May 1, 2024
@kyeong-hyeok kyeong-hyeok linked an issue May 1, 2024 that may be closed by this pull request
[Feature] 이동봉사자, 모집자 휴대폰 번호 중복 검사 API 구현 #167
Closed
3 tasks
hojeong2747
hojeong2747 approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@hojeong2747 hojeong2747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

휴대폰 번호 중복 검사 API에 계정 존재 안내까지 담아 구현하셨네요! 이미지를 반환하는 것보다 SocialType 반환하는 것이 훨씬 좋아 보입니다. 고생하셨어요 👍

@hojeong2747 hojeong2747 merged commit bffa116 into develop May 2, 2024
1 check passed
@hojeong2747 hojeong2747 deleted the feat/167-phone-isDuplicated-api branch May 2, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hojeong2747 hojeong2747 hojeong2747 approved these changes

Assignees
No one assigned
Labels
✨ Feature 기능 개발 🐯 Koeyhk 담당자 Priority: Low 우선순위 낮음
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] 이동봉사자, 모집자 휴대폰 번호 중복 검사 API 구현
2 participants
@kyeong-hyeok @hojeong2747