Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no parameter validation on create pictures function #43

Open
hebime opened this issue Aug 9, 2013 · 1 comment
Open

no parameter validation on create pictures function #43

hebime opened this issue Aug 9, 2013 · 1 comment
Milestone

Comments

@hebime
Copy link
Member

hebime commented Aug 9, 2013

I was able to still run the function without passing in the userId or eventId.
The queries still worked which might also mean that foreign keys aren't.
I think we're missing one from picture_events.eventId to events.id.
Fixed this by adding NOT NULL to both columns in the picture_events table;

Still need to add parameter validation.

@iToto
Copy link
Member

iToto commented Aug 9, 2013

hmm, yeah I was thinking about a nice way to do validation. I want to see there's a nice way to do before and after filters with express. That way we can write a universal validate function and call it before we route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants