Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Unicode and long-paths on Windows #194

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mnightingale
Copy link

Adds support for Unicode program arguments and long-paths using the \\?\ prefix on Windows.
Also converts filenames to the codepage in use by the console, so if supported won't result in question marks in the output.

The changes should have no affect on non-Windows builds, the utf8::* methods are no-ops.

References to a few useful resources used to arrive at this solution:

Resolves #189

@Safihre
Copy link
Contributor

Safihre commented Sep 1, 2024

@animetosho since there's not really a maintainer, maybe you could code review and pull the changes into par2cmdline turbo?
And maybe the same for #182 ?

@animetosho
Copy link
Contributor

Unfortunately I already stretched myself too thin with par2cmdline-turbo, so I want to stay far away from par2cmdline maintainer duties.

Appreciate the work people have put in with pull requests regardless - it goes to show there's still interest in the project. Perhaps this interest could lead to a new maintainer - maybe see if someone else is willing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly handle UTF8 and long-paths on Windows
3 participants