Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force function deployment every time #29

Merged
merged 5 commits into from
Dec 9, 2021
Merged

Force function deployment every time #29

merged 5 commits into from
Dec 9, 2021

Conversation

cleentfaar
Copy link
Contributor

No need for random strings anymore, at least should allow us to work around the buggy function deploy

see
hashicorp/terraform-provider-google#4871 (comment)
hashicorp/terraform-provider-google#1938

@cleentfaar cleentfaar requested a review from a team as a code owner December 9, 2021 10:16
barendregt
barendregt approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@barendregt barendregt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned, please test if this works on this branch before merging

@cleentfaar cleentfaar merged commit 85fd5ea into main Dec 9, 2021
@cleentfaar cleentfaar deleted the forcecfdeploy branch April 11, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barendregt barendregt barendregt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cleentfaar @barendregt