-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disguise api #10478
Open
yannicklamprecht
wants to merge
1
commit into
PaperMC:master
Choose a base branch
from
yannicklamprecht:feature/disguise-api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
disguise api #10478
yannicklamprecht
wants to merge
1
commit into
PaperMC:master
from
yannicklamprecht:feature/disguise-api
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
4 times, most recently
from
April 29, 2024 18:56
ce89b24
to
9c2de57
Compare
kashike
requested changes
Apr 29, 2024
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
from
April 29, 2024 20:03
9c2de57
to
c37d61b
Compare
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
11 times, most recently
from
May 4, 2024 13:00
0271101
to
d38b35d
Compare
MiniDigger
reviewed
May 4, 2024
MiniDigger
reviewed
May 4, 2024
MiniDigger
reviewed
May 4, 2024
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
4 times, most recently
from
May 4, 2024 14:05
cf41890
to
9d0fd05
Compare
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
from
June 17, 2024 19:32
113e119
to
4e293d8
Compare
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
from
July 6, 2024 19:40
4e293d8
to
c0697f2
Compare
good job! |
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
3 times, most recently
from
August 15, 2024 20:37
ad09e98
to
39e3f2f
Compare
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
2 times, most recently
from
August 31, 2024 18:28
f6b519e
to
8ad066c
Compare
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
from
September 9, 2024 16:11
8ad066c
to
7c703c7
Compare
Lulu13022002
reviewed
Oct 2, 2024
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
7 times, most recently
from
November 3, 2024 21:21
b9dd027
to
44df8ba
Compare
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
6 times, most recently
from
November 4, 2024 00:23
95a1c30
to
953e97a
Compare
yannicklamprecht
commented
Nov 4, 2024
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
from
November 9, 2024 21:28
953e97a
to
f2c75a3
Compare
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
2 times, most recently
from
November 19, 2024 09:09
6339760
to
f742741
Compare
and generate maps to allow entity metadata syncher validation
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
from
November 19, 2024 16:33
f742741
to
8104c58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #10584
Adds a simple disguise api that also makes sure that invalid entity data, not belonging to the type that is faked, is filtered.
It also adds a server generator module to reduce maintenance of the entity data filter.
tldr; The API provides a way to disguise any entity as another or a player with having the possibility to interact with the entity like with any others. The big advantage is that you've the whole vanilla logic and Mob Goal and Pathfinding included without hassle.
Testing the changes can be done using the following snippet:
https://gist.github.com/yannicklamprecht/639acba127a54f5617e1281f099b7aff
TODO:
figure out how to get teams working with real teams, client side ones worked in my forkNon issue just use theEntity#getName()
instead of theEntity#getScoreboardEntryName()
Effective loc: