Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llm] Add KTO #9689

Merged
merged 9 commits into from
Dec 31, 2024
Merged

[llm] Add KTO #9689

merged 9 commits into from
Dec 31, 2024

Conversation

lugimzzz
Copy link
Contributor

PR types

New features

PR changes

Others

Description

适配KTO

Copy link

paddle-bot bot commented Dec 24, 2024

Thanks for your contribution!

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 3.65854% with 79 lines in your changes missing coverage. Please review.

Project coverage is 52.77%. Comparing base (62274fa) to head (afd327b).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trl/trl_data.py 1.96% 50 Missing ⚠️
paddlenlp/transformers/kto_criterion.py 8.33% 22 Missing ⚠️
paddlenlp/datasets/zero_padding_dataset.py 0.00% 5 Missing ⚠️
paddlenlp/trl/kto_trainer.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9689      +/-   ##
===========================================
- Coverage    52.84%   52.77%   -0.07%     
===========================================
  Files          719      718       -1     
  Lines       113014   112449     -565     
===========================================
- Hits         59722    59350     -372     
+ Misses       53292    53099     -193     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,38 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些分布式策略是怎么确定的了?

@@ -0,0 +1,50 @@
# Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2022 -> 2024

wawltor
wawltor previously approved these changes Dec 30, 2024
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 3aa9f4c into PaddlePaddle:develop Dec 31, 2024
10 of 13 checks passed
@lugimzzz lugimzzz deleted the kto branch December 31, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants