Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove refined recompute deep copy #9617

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

JunnYu
Copy link
Member

@JunnYu JunnYu commented Dec 11, 2024

PR types

Function optimization

PR changes

APIs

Description

删除refined recompute对config的deep copy操作。
添加对应的文档介绍。

Copy link

paddle-bot bot commented Dec 11, 2024

Thanks for your contribution!

@JunnYu JunnYu requested a review from DesmonDay December 11, 2024 10:03
@@ -484,13 +484,13 @@ def forward(self, hidden_states):


class QWenBlock(nn.Layer):
def __init__(self, config):
def __init__(self, config, layer_idx: int = 0):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QwenBlock的外部调用,缺少了layer_idx的输入,可以检查一下。

@JunnYu JunnYu requested a review from ZHUI December 18, 2024 09:46
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 41.86047% with 25 lines in your changes missing coverage. Please review.

Project coverage is 52.80%. Comparing base (605a4ea) to head (927d157).
Report is 1 commits behind head on develop.

Current head 927d157 differs from pull request most recent head 2878179

Please upload reports for the commit 2878179 to get more accurate results.

Files with missing lines Patch % Lines
paddlenlp/transformers/llama/modeling.py 38.46% 8 Missing ⚠️
paddlenlp/transformers/qwen/modeling.py 42.85% 8 Missing ⚠️
paddlenlp/transformers/qwen2/modeling.py 38.46% 8 Missing ⚠️
paddlenlp/transformers/refined_recompute.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9617      +/-   ##
===========================================
+ Coverage    52.77%   52.80%   +0.02%     
===========================================
  Files          718      718              
  Lines       112154   112225      +71     
===========================================
+ Hits         59193    59262      +69     
- Misses       52961    52963       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants