Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config replace_with_c_embedding #9611

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Xing-lil
Copy link
Contributor

@Xing-lil Xing-lil commented Dec 11, 2024

PR types

Others

PR changes

Others

Description

Add replace_with_c_embedding in tensor_parallel_config, and add test.
Enable the pass by setting tensor_parallel_config to replace_with_c_embedding in YAML.
eg. tensor_parallel_config: replace_with_c_embedding

Copy link

paddle-bot bot commented Dec 11, 2024

Thanks for your contribution!

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.78%. Comparing base (c8aa7bf) to head (2b50d8b).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/training_args.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9611   +/-   ##
========================================
  Coverage    52.77%   52.78%           
========================================
  Files          709      709           
  Lines       111172   111174    +2     
========================================
+ Hits         58672    58682   +10     
+ Misses       52500    52492    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xing-lil Xing-lil closed this Dec 16, 2024
@Xing-lil Xing-lil force-pushed the replace_with_c_embedding branch from 66997e3 to c8aa7bf Compare December 16, 2024 05:19
@Xing-lil Xing-lil deleted the replace_with_c_embedding branch December 16, 2024 05:19
@Xing-lil Xing-lil restored the replace_with_c_embedding branch December 16, 2024 05:19
@Xing-lil Xing-lil reopened this Dec 16, 2024
@Xing-lil Xing-lil closed this Dec 16, 2024
@Xing-lil Xing-lil reopened this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants