Make ADSB handling in Navigator optional to save flash #24131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfuhrer
reviewed
Dec 19, 2024
MaEtUgR
force-pushed
the
optional-adsb
branch
from
d71a6e5 to
ac36e58
Compare
|
Yes, sorry it was the style check because on Mac I wasn't able to install this super old version of astyle from homebrew 🙄 |
sfuhrer
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When reviewing #24127 I had the idea to make this logic optional since I'm assuming it's rare to have an ADSB transponder attached to a racer board with constrained flash.
Solution
Like with the
CONFIG_MODE_NAVIGATOR_VTOL_TAKEOFFI made this feature of Navigator optional, enabled it by default but removed it from some flash constrained boards.Changelog Entry
Alternatives
The not-so-nice part is that the ADSB related uORB and MAVLink messages and drivers are completely separate.
Test coverage
The Kakute F7 build fits in flash again with this change.