Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make multicopter position control parameter descriptions more concise #24129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Dec 18, 2024

Solved Problem

When working on #24041 I found that Kakute F7 runs out of flash so @sfuhrer told me easiest is to save on some parameter description strings. But I think does are not included in flash-contained builds.

Even though there is no effect on that particular build I think cleaning up is worthwhile.

Solution

I shortened the texts to contain the essential information but avoid language decorations.

Changelog Entry

Improvement: Make multicopter position control parameter descriptions more concise

Copy link

🔎 FLASH Analysis

px4_fmu-v5x [Total VM Diff: -136 byte (-0.01 %)]
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +56  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -8  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -4  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
-0.0%     -20  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  +0.4%      +5  [ = ]       0    task/task_cancelpt.c
-0.0%      -8  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
+0.8%    +136  [ = ]       0    [Unmapped]
-0.0%    -136  -0.0%    -136    .text
  +0.0%      +4  +0.0%      +4    [section .text]
  -0.1%    -140  -0.1%    -140    ROMFS/nsh_romfsimg.c
+0.0%     +16  -0.0%    -136    TOTAL

px4_fmu-v6x [Total VM Diff: -152 byte (-0.01 %)]
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +56  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -8  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -4  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
-0.0%     -28  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  -0.3%      -3  [ = ]       0    task/task_cancelpt.c
-0.0%      -8  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
+0.2%    +152  [ = ]       0    [Unmapped]
-0.0%    -152  -0.0%    -152    .text
  -0.0%      -1  -0.0%      -1    [section .text]
  -0.1%    -151  -0.1%    -151    ROMFS/nsh_romfsimg.c
+0.0%      +8  -0.0%    -152    TOTAL

Updated: 2024-12-18T19:06:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant