Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding gimbal rate in gz simulation #24125

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Adding gimbal rate in gz simulation #24125

merged 2 commits into from
Dec 18, 2024

Conversation

Perrrewi
Copy link
Contributor

@Perrrewi Perrrewi commented Dec 18, 2024

Solved Problem

When I tested the gimbal device I notice the angular velocity data wasn't updated in the gimbal device attitude status.

Test coverage

Tested with QGC

Context

The original PR with results and description:

Below is the result of the gimbal in motion and corresponding angular velocities in the gimbal device attitude status.
07112024pr-gz-gimbal-sim.webm

@Perrrewi Perrrewi self-assigned this Dec 18, 2024
Copy link
Contributor

@StefanoColli StefanoColli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Perrrewi Perrrewi merged commit 8a93913 into main Dec 18, 2024
58 of 60 checks passed
@Perrrewi Perrrewi deleted the pernilla/add-gimbal-rate branch December 18, 2024 15:25
mbjd pushed a commit to mbjd/PX4-Autopilot that referenced this pull request Dec 18, 2024
* Adding gimbal rate in gz simulation

* add submodule
@MaEtUgR
Copy link
Member

MaEtUgR commented Dec 18, 2024

This pr must have updated the gz submodule to a hash that's not advertised by the remote. Let me have a look.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants