Add cleanup function for SITL Gazebo on macOS #24110
Open
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When running PX4 SITL on macOS, pressing Ctrl+C would not always cleanly stop the simulation processes (e.g., gz sim). This often forced users to press Ctrl+C multiple times or manually kill processes.
Solution
cleanup()
function guarded byif [ "$(uname)" = "Darwin" ]
.cleanup()
, usepkill -f "gz sim" || true
to stop Gazebo simulation processes.trap
forINT TERM
signals right beforeexit 0
.Changelog Entry
For release notes:
Alternatives
We could also add a
kill 0
call or a broader signal handling mechanism, butpkill -f "gz sim"
suffices for macOS SITL with minimal side effects.Test coverage
Context
N/A
I cannot add reviewers here. @mrpollo @MaEtUgR @ThomasDebrunner you might want to try.