analog_battery: add option for filter #23987
Open
+51
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about tuning the existing filters already in Battery (AnalogBattery inherits) instead? PX4-Autopilot/src/lib/battery/battery.cpp Lines 56 to 59 in cdc6fc4 |
|
Hm, those filters won't adjust the current or voltage reading. This would still be the data. |
AlexKlimaj
force-pushed
the
pr-adc-battery-filter
branch
from
cdc6fc4 to
a0196ae
Compare
|
I would do this with an actual AlphaFilter. PX4-Autopilot/src/lib/battery/battery.h Line 168 in cdc6fc4 I can help you do it quickly if it's not clear. |
AlexKlimaj
force-pushed
the
pr-adc-battery-filter
branch
from
a0196ae to
8bd9e34
Compare
|
With the Alpha filter. https://review.px4.io/plot_app?log=31640ae9-2d42-49f3-bc9e-4a72b844fc05
|
|
I can probably use a much shorter filter window. |
mrpollo
force-pushed
the
pr-adc-battery-filter
branch
from
8bd9e34 to
0c53dac
Compare
AlexKlimaj
force-pushed
the
pr-adc-battery-filter
branch
from
0c53dac to
1484982
Compare
|
@dagar any more input? |
AlexKlimaj
force-pushed
the
pr-adc-battery-filter
branch
from
1484982 to
42f705b
Compare
AlexKlimaj
force-pushed
the
pr-adc-battery-filter
branch
from
42f705b to
3dfb36e
Compare
|
Updated with the new per update dt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to filter the adc output of voltage and current.
When pulling voltage from the on board voltage divider and current from an ESC current shunt, the noise can be very high.
https://review.px4.io/plot_app?log=96629307-87c9-4f68-a112-b49e2abe34ac#Nav-Power
Raw voltage vs moving average of 10.
Raw current vs on board battery lib average current. And ESC reported current from the same shunt vs moving average of 25.
