-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PR2 calibration by using hacked version of urdf_parser_py by overwriting PYTHONPATH in the shell scripts. #6
Conversation
garaemon
commented
Dec 2, 2014
- add pr2_urdf_parser_py directory by copying from Fix for pr2_calibration package to work ros/urdfdom#55
- overwrite PYTHONPATH when running multi_step_cov_estimator.py to use urdf_parser_py under pr2_urdf_parser_py directory instead of official urdf_parser_py
- You can test calibration by https://drive.google.com/file/d/0B4bnoIcbRJVuVWVqT1ExR0hvcEE/view?usp=sharing
@@ -1,4 +1,4 @@ | |||
<launch> | |||
<<launch> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is probably wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
overwriting PYTHONPATH in the shell scripts.
a0fa8ed
to
162b1b4
Compare
I'll give this a test on our PR2 and get back to this thread in 5 minutes. |
This code is copied from the old urdfdom, right? Edit: nevermind, I should read more before replying |
nop, copied from the pull request nit merged into urdfdom by @k-okada 2014年12月2日火曜日、Devon [email protected]さんは書きました:
from iPhone |
Just to confirm to those who are interested: the pr2_recalibrate.launch process is not the calibration process that is under issue. I've tested this on our robot and it works. Have you tried this on your robot @garaemon ? |
I don't know pr2_recalibrate.launch launch file. where can I find it? |
about estimate_pr2_beta_urdf.sh, it works on my environment. |
pr2_recalibrate.launch exists inside pr2_bringup /opt/ros/hydro/share/pr2_bringup/ I'm not sure how it's different from pr2_calibration_launch.. The pr2_calibration_launch seems to be what is used to generate the initial URDF and the pr2_recalibrate is to.. fine tune later? |
Fix PR2 calibration by using hacked version of urdf_parser_py by overwriting PYTHONPATH in the shell scripts.
I didn't know that.
I think we need to run pr2_recablirate before capturing data only if encode has large error. |
This is fixed now yeah? |
Yes, fixed |
Thanks @garaemon |