Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR2 calibration by using hacked version of urdf_parser_py by overwriting PYTHONPATH in the shell scripts. #6

Conversation

garaemon
Copy link
Contributor

@garaemon garaemon commented Dec 2, 2014

@@ -1,4 +1,4 @@
<launch>
<<launch>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

overwriting PYTHONPATH in the shell scripts.
@garaemon garaemon force-pushed the use-hacked-version-of-urdf-parser-py branch from a0fa8ed to 162b1b4 Compare December 2, 2014 08:19
@UltronDestroyer
Copy link
Contributor

I'll give this a test on our PR2 and get back to this thread in 5 minutes.

@UltronDestroyer
Copy link
Contributor

This code is copied from the old urdfdom, right?

Edit: nevermind, I should read more before replying

@garaemon
Copy link
Contributor Author

garaemon commented Dec 2, 2014

nop, copied from the pull request nit merged into urdfdom by @k-okada

2014年12月2日火曜日、Devon [email protected]さんは書きました:

This code is copied from the old urdfdom, right?


Reply to this email directly or view it on GitHub
#6 (comment).

from iPhone

@UltronDestroyer
Copy link
Contributor

Just to confirm to those who are interested: the pr2_recalibrate.launch process is not the calibration process that is under issue.

I've tested this on our robot and it works. Have you tried this on your robot @garaemon ?

@garaemon
Copy link
Contributor Author

garaemon commented Dec 2, 2014

Just to confirm to those who are interested: the pr2_recalibrate.launch process is not the calibration process that is under issue.

I don't know pr2_recalibrate.launch launch file. where can I find it?

@garaemon
Copy link
Contributor Author

garaemon commented Dec 3, 2014

about estimate_pr2_beta_urdf.sh, it works on my environment.

@UltronDestroyer
Copy link
Contributor

pr2_recalibrate.launch exists inside pr2_bringup

/opt/ros/hydro/share/pr2_bringup/

I'm not sure how it's different from pr2_calibration_launch.. The pr2_calibration_launch seems to be what is used to generate the initial URDF and the pr2_recalibrate is to.. fine tune later?

UltronDestroyer added a commit that referenced this pull request Dec 3, 2014
Fix PR2 calibration by using hacked version of urdf_parser_py by overwriting PYTHONPATH in the shell scripts.
@UltronDestroyer UltronDestroyer merged commit 530b741 into PR2:hydro-devel Dec 3, 2014
@garaemon garaemon deleted the use-hacked-version-of-urdf-parser-py branch December 3, 2014 04:10
@garaemon
Copy link
Contributor Author

garaemon commented Dec 3, 2014

I didn't know that.

The pr2_calibration_launch seems to be what is used to generate the initial URDF and the pr2_recalibrate is to.. fine tune later?

I think we need to run pr2_recablirate before capturing data only if encode has large error.
But I think the encoders has good precision according to the calibration when starting up pr2.

@UltronDestroyer
Copy link
Contributor

This is fixed now yeah?

@garaemon
Copy link
Contributor Author

Yes, fixed

@UltronDestroyer
Copy link
Contributor

Thanks @garaemon

wkentaro referenced this pull request in wkentaro/pr2_calibration Jun 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants