Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed missing images #829 #833

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: Fixed missing images #829 #833

wants to merge 5 commits into from

Conversation

kw-pr
Copy link
Contributor

@kw-pr kw-pr commented Dec 12, 2024 •
edited
Loading

Description

Added setContainer in Slide/AbstractSlide::createDrawingShape().

Fixes #820 createDrawingShape stopped working in 1.1.0

See #820 (comment) for details.

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

I think extra tests is not needed for a bugfix. There is no new code, not really.

@auto-assign auto-assign bot requested a review from Progi1984 December 12, 2024 12:06
@kw-pr kw-pr mentioned this pull request Dec 12, 2024
Closed
4 tasks
@kw-pr
Copy link
Contributor Author

kw-pr commented Dec 17, 2024

@Progi1984 What do you think about this?
I noticed you merged the other PRs but not this. I know this is one is more complicated. :)
I already put a lot of effort into this and would appreciate your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 left review comments

Assignees

@Progi1984 Progi1984

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createDrawingShape stopped working in 1.1.0
2 participants
@kw-pr @Progi1984