This repository has been archived by the owner on Jan 2, 2019. It is now read-only.
Throw InvalidArgumentException in case getint4d fails #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r .xlsx file ( when OLERead fails to detect size of cell blocks and goes in infinite loop) : changed code according to PSR2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed a case where function "private static function getInt4d($data, $pos)" in OLERead.php file fails to read 4 bytes of data from corrupted block. It is not feasible to make changes everywhere, hence we are throwing InvalidArgumentException which will make sure that we do not end up with infinite looping in any situation. Please parse sample files attached in the zip archive.
test.zip