Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch parts of config parsing to PGMs TextParser.parseComponent #61

Merged
merged 1 commit into from
May 27, 2024

Conversation

cswhite2000
Copy link
Member

@cswhite2000 cswhite2000 commented May 26, 2024

Switches some config messages to TextParser.parseString

This method accepts the old legacy strings and handles them the same way, which prevents this from breaking old Community configs. The main difference is that this can now also accept Minecraft JSON formatted strings.

This is the same parser the <text> XML component uses.

Really basic example:

Screenshot 2024-05-25 at 6 51 00 PM

The main reason for making this change is that /ranks does not have the same hover messages as normal chat ranks.

@applenick applenick merged commit a7b0506 into dev May 27, 2024
2 checks passed
@applenick applenick deleted the config-json branch May 27, 2024 07:35
@applenick
Copy link
Member

Nice work! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants