-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Cloud 2.0 and adapt to upstream changes #59
Conversation
Signed-off-by: BT (calcastor/mame) <[email protected]>
Signed-off-by: BT (calcastor/mame) <[email protected]>
Signed-off-by: BT (calcastor/mame) <[email protected]>
This reverts commit 88c2666. Signed-off-by: BT (calcastor/mame) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the confirmation manager like we did in PGMDev/PGM#1319 but let me know if this should be maintained.
To answer this question, I don't believe we used it anywhere so totally fine to remove 👍
@calcastor Everything looks good! Before merging, I'll do some local testing myself. Have you had a chance to test this further since the initial opening of the PR? While I doubt there will be any issues, it's always a good practice to double-check.
Signed-off-by: BT (calcastor/mame) <[email protected]>
I have not unfortunately as I do not have a database set up at the moment. |
WIP update to Cloud 2.0, depends on PGMDev/PGM#1319
I removed the confirmation manager like we did in PGMDev/PGM#1319 but let me know if this should be maintained.
Currently untested beyond ensuring it builds against the aforementioned PGM PR.