Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cloud 2.0 and adapt to upstream changes #59

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

calcastor
Copy link
Contributor

WIP update to Cloud 2.0, depends on PGMDev/PGM#1319

I removed the confirmation manager like we did in PGMDev/PGM#1319 but let me know if this should be maintained.

Currently untested beyond ensuring it builds against the aforementioned PGM PR.

@calcastor calcastor changed the title Update to Cloud v2.0 Update to Cloud 2.0 May 20, 2024
@calcastor calcastor marked this pull request as ready for review May 30, 2024 05:21
Signed-off-by: BT (calcastor/mame) <[email protected]>
Signed-off-by: BT (calcastor/mame) <[email protected]>
Signed-off-by: BT (calcastor/mame) <[email protected]>
pom.xml Outdated Show resolved Hide resolved
This reverts commit 88c2666.

Signed-off-by: BT (calcastor/mame) <[email protected]>
Copy link
Member

@applenick applenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the confirmation manager like we did in PGMDev/PGM#1319 but let me know if this should be maintained.

To answer this question, I don't believe we used it anywhere so totally fine to remove 👍

@calcastor Everything looks good! Before merging, I'll do some local testing myself. Have you had a chance to test this further since the initial opening of the PR? While I doubt there will be any issues, it's always a good practice to double-check.

Signed-off-by: BT (calcastor/mame) <[email protected]>
@calcastor calcastor changed the title Update to Cloud 2.0 Update to Cloud 2.0 and adapt to upstream changes Jun 12, 2024
@calcastor
Copy link
Contributor Author

I removed the confirmation manager like we did in PGMDev/PGM#1319 but let me know if this should be maintained.

To answer this question, I don't believe we used it anywhere so totally fine to remove 👍

@calcastor Everything looks good! Before merging, I'll do some local testing myself. Have you had a chance to test this further since the initial opening of the PR? While I doubt there will be any issues, it's always a good practice to double-check.

I have not unfortunately as I do not have a database set up at the moment.

@applenick applenick merged commit 384d715 into PGMDev:dev Jun 12, 2024
2 checks passed
@calcastor calcastor deleted the cloud-2.0 branch June 14, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants