Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USB: ASCII Trance Vib emulation #11616

Merged
merged 1 commit into from
Jul 27, 2024
Merged

USB: ASCII Trance Vib emulation #11616

merged 1 commit into from
Jul 27, 2024

Conversation

Florin9doi
Copy link
Contributor

@Florin9doi Florin9doi commented Jul 23, 2024 •
edited
Loading

Description of Changes

Add ASCII Trance Vib emulation

Suggested Testing Steps

Check the following games:

Game Supported
Rez ✅
Space Channel 5 Part 2 ✅
Zettai Zetsumei Toshi ✅
Disaster Report ❌
SOS: The Final Escape ❌

@Florin9doi Florin9doi mentioned this pull request Jul 23, 2024
Open
39 tasks
@JordanTheToaster
Copy link
Member

Also if you could write a proper PR description that would be good.

F0bes
F0bes approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@F0bes F0bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested Rez and it detects and uses the device. The vibration worked fine on my controller.

@F0bes F0bes merged commit edd39df into PCSX2:master Jul 27, 2024
12 checks passed
@Florin9doi Florin9doi deleted the trv branch July 27, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanTheToaster JordanTheToaster JordanTheToaster requested changes

@F0bes F0bes F0bes approved these changes

Assignees
No one assigned
Labels
Build | Project System GUI/Qt USB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Florin9doi @JordanTheToaster @F0bes