VU: Expand IBit hack to work for immediates on several instructions #11117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractionpcsx2
force-pushed
the
vu_expandibithack
branch
from
12e0a5a
to
5811ab1
Compare
kamfretoz
approved these changes
Apr 21, 2024
stenzek
reviewed
Apr 23, 2024
refractionpcsx2
force-pushed
the
vu_expandibithack
branch
from
5811ab1
to
06df371
Compare
|
Returning nullopt in Assembly changes LGTM, untested. |
JordanTheToaster
approved these changes
Apr 24, 2024
kamfretoz
approved these changes
Apr 24, 2024
refractionpcsx2
force-pushed
the
vu_expandibithack
branch
from
06df371
to
dcd8731
Compare
Done :) |
refractionpcsx2
force-pushed
the
vu_expandibithack
branch
from
dcd8731
to
ffb586c
Compare
refractionpcsx2
force-pushed
the
vu_expandibithack
branch
from
ffb586c
to
4a6e46a
Compare
Mrlinkwii
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Expand the IBit hack to several commands using immediates, to help reduce recompilation on games which modify these values a lot.
Rationale behind Changes
Games like Shellshock - Nam '67 and Killzone modify their VU programs a lot, changing immediate values and nothing else in several cases, This expands the IBit hack to try and ignore these differences and load the values from RAM instead of compiling new program.
Suggested Testing Steps
Test Shellshock - Nam '67, Killzone, Scarface and Crash Tag Team racing. If you know any other games that recompile constantly, try enabling the IBit gamefix and see if that helps.
Reduces VU compilation in Killzone by about half
Reduces VU compilation in Shellshock - Nam '67 by roughly 10% (reduces hitching by a bit)