Refactored the command classes that adds stats #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebuilderbob1
changed the title
|
Are the config.yaml changes required for this PR? If so could you please explain the reason |
|
no, disregard those. I set some options to login faster for testing |
P0nk
requested changes
Aug 28, 2024
Comment on lines
+13
to
+16
| @Override | ||
| public void execute(Client client, String[] params) { | ||
| super.execute(client, params); | ||
| } |
There was a problem hiding this comment.
What's the point of these 4 identical execute implementations in all the subclasses? It's already implemented in StatCommand.
Comment on lines
+367
to
+370
| //addCommand("str", StatStrCommand.class); | ||
| //addCommand("dex", StatDexCommand.class); | ||
| //addCommand("int", StatIntCommand.class); | ||
| //addCommand("luk", StatLukCommand.class); |
There was a problem hiding this comment.
Remove these comments and delete the old commands since they are useless now.
| AssignStat(c, params, stat); | ||
| } | ||
|
|
||
| private void AssignStat(Client client, String[] params, Stat stat) |
There was a problem hiding this comment.
camelCase method name is Java standard
Comment on lines
162
to
166
| DB_URL_FORMAT: "jdbc:mysql://%s:3306/cosmic" # If the docker ENV for DB_HOST is anything but "db", this string format should be changed from 3306 to 3307 (or whichever port it was changed to in docker) | ||
| DB_HOST: "localhost" | ||
| DB_USER: "root" | ||
| DB_PASS: "" | ||
| DB_PASS: "root" | ||
| INIT_CONNECTION_POOL_TIMEOUT: 90 # Seconds |
There was a problem hiding this comment.
No need to commit your own changes to config.yaml. Please revert all the changes to this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist before requesting a review
Screenshots