Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency jsonpath-plus to 10.0.0 due to vulnerability #13

Closed
wants to merge 1 commit into from

Conversation

knowacki23
Copy link

This is a simple dependency bump of the jsonpath-plus dependency.

This dependency is vulnerable according to Snyk: https://security.snyk.io/vuln/SNYK-JS-JSONPATHPLUS-7945884
As this is a non-major upgrade and I have not seen the vulnerability being mentioned anywhere in the repository I thought I'd open a PR for it.

@P0lip
Copy link
Owner

P0lip commented Oct 14, 2024

Could you please update the lockfile as well?
Also, it'd be good to change the commit title to chore(deps) as this change has no impact on the package code itself as mentiond here.
Nimma no longer relies on jsonpath-plus and we have it listed as a dev dependency only to use in test suites to compare Nimma results with those from jsonpath-plus.

Copy link

sonarcloud bot commented Oct 15, 2024

@knowacki23 knowacki23 changed the title fix(deps): update dependency jsonpath-plus to 10.0.0 due to vulnerability chore(deps): update dependency jsonpath-plus to 10.0.0 due to vulnerability Oct 15, 2024
@knowacki23
Copy link
Author

Updated package-lock.json and updated commit and PR titles

"version": "8.1.0",
"resolved": "https://registry.npmjs.org/jsonpath-plus/-/jsonpath-plus-8.1.0.tgz",
"integrity": "sha512-qVTiuKztFGw0dGhYi3WNqvddx3/SHtyDT0xJaeyz4uP0d1tkpG+0y5uYQ4OcIo1TLAz3PE/qDOW9F0uDt3+CTw==",
"version": "10.0.0",
Copy link

@johannesmarx johannesmarx Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @knowacki23, could you please update again?
Your source reports that versions < 10.0.7 are affected. Thanks a lot 👍

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the semver ^10.0.0 pull in the newest 10.1.0 version? https://classic.yarnpkg.com/lang/en/docs/dependency-versions/#toc-caret-ranges

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make the library build consistent and working with version 10.1.0, package-lock.json should also be updated (again) to show explicitly that it's using a version >= 10.0.7.

@coreydaley
Copy link

@johannesmarx I opened #14 with the requested changes.
Based on another pull request from @knowacki23 (asyncapi/parser-js#1056) I don't feel as though they are going to update this one.

@P0lip
Copy link
Owner

P0lip commented Nov 17, 2024

@knowacki23 thanks for the PR.
I decided to drop jsonpath-plus in 17faf59.
It was only a dev dependency that wasn't really needed for anything other than convenience.

@P0lip P0lip closed this Nov 17, 2024
@coreydaley
Copy link

@P0lip Would you mind doing a new release now that it is removed?

@P0lip
Copy link
Owner

P0lip commented Nov 18, 2024

I don't think we need to.
Let me explain. Nimma wasn't vulnerable. jsonpath-plus was only a dev dependency that was used in one test suite.
In a typical setup, dev dependencies aren't installed when you install an npm package. In other words, when one adds nimma to their project, only astring (the only runtime dep Nimma requires) would be installed apart from nimma itself.
As such, the latest version of nimma should pass scanners that check for outdated/vulnerable dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants