Add OnConsoleMessage from browser #351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaompneves
requested changes
Sep 3, 2024
WebViewControl/WebView.cs
Outdated
| @@ -72,6 +72,7 @@ public partial class WebView : IDisposable { | |||
| public event Action TitleChanged; | |||
| public event UnhandledAsyncExceptionEventHandler UnhandledAsyncException; | |||
| public event Action</*url*/string> PopupOpening; | |||
| public event ConsoleMessageEventHandler OnConsoleMessage; | |||
There was a problem hiding this comment.
Missing the ConsoleMessageEventHandler
Also OnConsoleMessage should be ConsoleMessageEmitted
There was a problem hiding this comment.
Hello, I changed OnConsoleMessage to ConsoleMessageEmitted.
For me Xilium.CefGlue.Common.Events has ConsoleMessageEventHandler and there is an import to it in WebView.cs
using Xilium.CefGlue.Common.Events;
Would it be recommended to recreate it in the webview project? Thank you.
There was a problem hiding this comment.
Hi,
Yes. The webview doesn't/shouldn't expose anything from CefGlue
There was a problem hiding this comment.
Thank you. I think I got everything properly recreated in the webview control in latest commit.
added 2 commits
September 4, 2024 11:21
…ogSeverity in the webviewcontrol namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes ConsoleMessage to webview. I am using it for debugging purposes here.