SFT Roles Registry #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added recordInfo function. * refactor both implementations. * fixed bug on _findCaller.
…tedTokens respectively
…are no non-revocable roles
…wn to TokensReleased
karacurt
reviewed
Jan 8, 2024
karacurt
reviewed
Jan 9, 2024
contracts/RolesRegistry/interfaces/ICommitTokensAndGrantRoleExtension.sol
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor SFT Roles Registry standard to accommodate a wider range of implementations. Here is the summary of the changes:
recordtocommitment. The user now calls the functioncommitTokensinstead ofcreateRecord.Commitmentmore intuitive as different implementations can allow users to commit tokens either by depositing on the contract or by freezing assets (record was too vague).ICommitTokensAndGrantRoleExtension, allowing users to commit tokens and grant roles in a single transaction.IRoleBalanceOfExtension, allowing dapps to easily fetch the number of tokens delegated to an user._findCallerthat preventedgranteeto revoke roles before they expire.Other less important changes:
noncetoitemId.