On 932 update marketplace sft #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 4, 2024 12:21
… Fixture to add new constructor parameter
…d call legacy interface
ernanirst
requested changes
Jul 9, 2024
contracts/interfaces/IERC7589LockTokensAndGrantRoleExtension.sol
Outdated
Show resolved
Hide resolved
ernanirst
requested changes
Jul 12, 2024
| @@ -102,7 +102,7 @@ library LibOriumSftMarketplace { | |||
| "OriumSftMarketplace: tokenAmount provided does not match commitment's tokenAmount" | |||
| ); | |||
| require( | |||
| _rolesRegistry.grantorOf(_commitmentId) == _expectedGrantor, | |||
| _rolesRegistry.ownerOf(_commitmentId) == _expectedGrantor, | |||
There was a problem hiding this comment.
Unresolving this as we need to call grantorOf when it's Wearables
ernanirst
requested changes
Jul 12, 2024
ernanirst
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.